aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Gubler <thomasgubler@gmail.com>2014-12-02 12:25:03 +0100
committerThomas Gubler <thomasgubler@gmail.com>2014-12-02 12:25:03 +0100
commit7328cc4a1920285988c9b7bd8f2a0c19149c9aa2 (patch)
tree5c759ffa2de476e0c8bf152c192b24aaef6bf0d3
parente28e8c11bba0779386fc16ee47deac4db39b51c0 (diff)
parentb4da5afcce1b1b4806d4583ee04ad126bbba8e01 (diff)
downloadpx4-firmware-7328cc4a1920285988c9b7bd8f2a0c19149c9aa2.tar.gz
px4-firmware-7328cc4a1920285988c9b7bd8f2a0c19149c9aa2.tar.bz2
px4-firmware-7328cc4a1920285988c9b7bd8f2a0c19149c9aa2.zip
Merge remote-tracking branch 'upstream/master' into dev_ros
-rw-r--r--src/drivers/rgbled/rgbled.cpp14
-rw-r--r--src/modules/commander/accelerometer_calibration.cpp10
2 files changed, 12 insertions, 12 deletions
diff --git a/src/drivers/rgbled/rgbled.cpp b/src/drivers/rgbled/rgbled.cpp
index 13cbfdfa8..d35722244 100644
--- a/src/drivers/rgbled/rgbled.cpp
+++ b/src/drivers/rgbled/rgbled.cpp
@@ -121,7 +121,7 @@ private:
/* for now, we only support one RGBLED */
namespace
{
-RGBLED *g_rgbled;
+RGBLED *g_rgbled = nullptr;
}
void rgbled_usage();
@@ -680,15 +680,15 @@ rgbled_main(int argc, char *argv[])
ret = ioctl(fd, RGBLED_SET_MODE, (unsigned long)RGBLED_MODE_OFF);
close(fd);
+ /* delete the rgbled object if stop was requested, in addition to turning off the LED. */
+ if (!strcmp(verb, "stop")) {
+ delete g_rgbled;
+ g_rgbled = nullptr;
+ exit(0);
+ }
exit(ret);
}
- if (!strcmp(verb, "stop")) {
- delete g_rgbled;
- g_rgbled = nullptr;
- exit(0);
- }
-
if (!strcmp(verb, "rgb")) {
if (argc < 5) {
errx(1, "Usage: rgbled rgb <red> <green> <blue>");
diff --git a/src/modules/commander/accelerometer_calibration.cpp b/src/modules/commander/accelerometer_calibration.cpp
index 0cb41489f..d4cd97be6 100644
--- a/src/modules/commander/accelerometer_calibration.cpp
+++ b/src/modules/commander/accelerometer_calibration.cpp
@@ -263,7 +263,7 @@ int do_accel_calibration_measurements(int mavlink_fd, float accel_offs[3], float
const int samples_num = 2500;
float accel_ref[6][3];
bool data_collected[6] = { false, false, false, false, false, false };
- const char *orientation_strs[6] = { "front", "back", "left", "right", "top", "bottom" };
+ const char *orientation_strs[6] = { "back", "front", "left", "right", "up", "down" };
int sensor_combined_sub = orb_subscribe(ORB_ID(sensor_combined));
@@ -294,12 +294,12 @@ int do_accel_calibration_measurements(int mavlink_fd, float accel_offs[3], float
/* inform user which axes are still needed */
mavlink_log_info(mavlink_fd, "pending: %s%s%s%s%s%s",
- (!data_collected[0]) ? "front " : "",
- (!data_collected[1]) ? "back " : "",
+ (!data_collected[5]) ? "down " : "",
+ (!data_collected[0]) ? "back " : "",
+ (!data_collected[1]) ? "front " : "",
(!data_collected[2]) ? "left " : "",
(!data_collected[3]) ? "right " : "",
- (!data_collected[4]) ? "up " : "",
- (!data_collected[5]) ? "down " : "");
+ (!data_collected[4]) ? "up " : "");
/* allow user enough time to read the message */
sleep(3);