summaryrefslogtreecommitdiff
path: root/apps/system/zmodem/Kconfig
diff options
context:
space:
mode:
authorGregory Nutt <gnutt@nuttx.org>2013-07-14 17:01:23 -0600
committerGregory Nutt <gnutt@nuttx.org>2013-07-14 17:01:23 -0600
commita9ac8ee92de976a5450e3a060a561e22094f4d60 (patch)
tree8b1201d325c23a980f2f67617dfdf8b502f99932 /apps/system/zmodem/Kconfig
parentebc9e1858b5c0d534cbd9fe0e52ceeebecabe241 (diff)
downloadpx4-nuttx-a9ac8ee92de976a5450e3a060a561e22094f4d60.tar.gz
px4-nuttx-a9ac8ee92de976a5450e3a060a561e22094f4d60.tar.bz2
px4-nuttx-a9ac8ee92de976a5450e3a060a561e22094f4d60.zip
Fix some Zmodem buffer sizing issues
Diffstat (limited to 'apps/system/zmodem/Kconfig')
-rw-r--r--apps/system/zmodem/Kconfig13
1 files changed, 10 insertions, 3 deletions
diff --git a/apps/system/zmodem/Kconfig b/apps/system/zmodem/Kconfig
index a622e9e8e..7d84d1812 100644
--- a/apps/system/zmodem/Kconfig
+++ b/apps/system/zmodem/Kconfig
@@ -22,15 +22,22 @@ config SYSTEM_ZMODEM_RCVBUFSIZE
int "Receive buffer size"
default 512
---help---
- The size of one buffer used to read data from the remote peer.
+ The size of one buffer used to read data from the remote peer. The
+ total buffering capability is SYSTEM_ZMODEM_RCVBUFSIZE plus the size
+ of the RX buffer in the device driver. If you are using a serial
+ driver with, say, USART0. That that buffering capability includes
+ USART0_RXBUFFERSIZE. This total buffering capability must be
+ significantly larger than SYSTEM_ZMODEM_PKTBUFSIZE (larger due
+ streaming race conditions, data expansion due to escaping, and
+ possible protocol overhead).
config SYSTEM_ZMODEM_PKTBUFSIZE
int "Maximum packet size"
default 512
---help---
Data may be received in gulps of varying size and alignment.
- Received packets data is properly packed into a packet buffer of
- this size.
+ Received packets data is properly unescaped, aligned and packed
+ into a packet buffer of this size.
config SYSTEM_ZMODEM_SNDBUFSIZE
int "Send buffer size"